[crac] RFR: 8355974: [CRaC] Move CPUFeatures verification to the parent process of JVM [v16]

Jan Kratochvil jkratochvil at openjdk.org
Mon May 19 11:57:10 UTC 2025


On Mon, 19 May 2025 07:43:41 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Wrap cpufeatures_store() by VM_Version::ignore_cpu_features()
>
> src/hotspot/cpu/x86/vm_version_x86.cpp line 2613:
> 
>> 2611: 
>> 2612: bool VM_Version::cpu_features_binary_check(const CPUFeaturesBinary *data) {
>> 2613:   ResourceMark rm;
> 
> Is this `ResourceMark` still needed? I can't see where it might be used.

I agree, thanks, fixed in: f2e0280f0130732a149a14b76e8e8f26b24f338e

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/227#discussion_r2095540814


More information about the crac-dev mailing list