[crac] RFR: 8369566: CRaC: Record metrics during checkpoint [v3]

[Radim Vansa]

On Thu, 16 Oct 2025 12:50:09 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix for PathPatternTest
>
> src/java.base/share/classes/jdk/internal/crac/Score.java line 60:
> 
>> 58:      * recording metadata this is ignored.
>> 59:      * On checkpoint the metrics are not reset; if that is desired invoke {@link #resetAll()}
>> 60:      * manually.
> 
> BTW we should also be documenting this on the engine API level: whether something is reset on checkpoint or not. AFAIR user data is reset, constraints are not, scores — I haven't checked yet. This can be postponed until we claim the support of repeated checkpoints, I am just saying.

Good point. I think that we're not resetting on the engine level ATM, but we should: otherwise the Java-space `resetAll()` is not effective.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/269#discussion_r2446849467