[crac] RFR: 8369566: CRaC: Record metrics during checkpoint [v3]

[Radim Vansa]

On Thu, 16 Oct 2025 13:25:18 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix for PathPatternTest
>
> src/hotspot/share/runtime/crac_engine.hpp line 76:
> 
>> 74: 
>> 75:   ApiStatus prepare_image_score_api();
>> 76:   bool set_score(const char* metric, double value);
> 
> Suggestion:
> 
>   bool set_score(const char* metric, double value) const;

While technically it is possible to mark this as `const`, I don't like the message this sends: `_conf` is "owned" by `CRaCEngine`, I consider that an opaque part of its state. But `set_score` mutates the configuration.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/269#discussion_r2446876797