[crac] RFR: 8369566: CRaC: Record metrics during checkpoint [v3]
Radim Vansa
rvansa at openjdk.org
Tue Oct 21 06:52:38 UTC 2025
On Thu, 16 Oct 2025 13:43:25 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix for PathPatternTest
>
> src/hotspot/share/runtime/crac.cpp line 733:
>
>> 731:
>> 732: double uptime = TimeHelper::counter_to_millis(os::elapsed_counter());
>> 733: result = result && _engine->set_score("vm.boot_time", os::javaTimeMillis() - uptime);
>
> Shouldn't `boot_time()` use `TimeHelper` too?
I had it there, but then I realized that `TimeHelper::counter_to_millis` uses `double` as the return type.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/269#discussion_r2446894952
More information about the crac-dev
mailing list