[crac] RFR: 8369566: CRaC: Record metrics during checkpoint [v3]
Radim Vansa
rvansa at openjdk.org
Tue Oct 21 06:56:42 UTC 2025
On Thu, 16 Oct 2025 13:47:02 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix for PathPatternTest
>
> src/hotspot/share/runtime/crac.cpp line 746:
>
>> 744: result = result && _engine->set_score("java.cls.sharedUnloadedClasses", shared_unloaded_classes);
>> 745: #endif // INCLUDE_MANAGEMENT
>> 746: result = result && _engine->set_score("sun.cls.appClassLoadCount", ClassLoader::perf_app_classload_count()->get_value());
>
> `ClassLoader::perf_app_classload_count()` should return null when `UsePerfData` is false. Worth to check the other counters too.
Good catch, there should be a test variant with `-XX:-UsePerfData`
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/269#discussion_r2446904947
More information about the crac-dev
mailing list