[crac] RFR: 8369566: CRaC: Record metrics during checkpoint [v3]

[Radim Vansa]

On Thu, 16 Oct 2025 13:35:36 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix for PathPatternTest
>
> src/hotspot/share/runtime/crac.cpp line 715:
> 
>> 713:   ResourceMark rm;
>> 714:   objArrayOop metrics_oops = objArrayOop(JNIHandles::resolve_non_null(metrics));
>> 715:   typeArrayOop values_oops = typeArrayOop(JNIHandles::resolve_non_null(values));
> 
> To be clearer that these are just casts and not construction+copy
> Suggestion:
> 
>   const auto metrics_oops = static_cast<objArrayOop>(JNIHandles::resolve_non_null(metrics));
>   const auto values_oops = static_cast<typeArrayOop>(JNIHandles::resolve_non_null(values));

Using `oop_cast` - there's only one case of such static_cast in the codebase, so I'll go with the (other) standard way.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/269#discussion_r2451794487