[crac] RFR: 8369566: CRaC: Record metrics during checkpoint [v3]
Radim Vansa
rvansa at openjdk.org
Wed Oct 22 11:50:51 UTC 2025
On Thu, 16 Oct 2025 14:05:26 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix for PathPatternTest
>
> src/java.base/share/native/libcrexec/image_score.hpp line 40:
>
>> 38: struct Score {
>> 39: const char* _name;
>> 40: double _value;
>
> Since these are public it would be better not to have a leading underscore
From: https://wiki.openjdk.org/display/HotSpot/StyleGuide#StyleGuide-Names
> Instance variable names start with underscore "_", classes start with upper case letter, local functions are all lower case, all must have meaningful names.
No distinction on public/private
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/269#discussion_r2451820283
More information about the crac-dev
mailing list