[crac] RFR: 8369566: CRaC: Record metrics during checkpoint [v3]
Timofei Pushkin
tpushkin at openjdk.org
Thu Oct 23 07:35:46 UTC 2025
On Wed, 22 Oct 2025 11:48:26 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
>> src/java.base/share/native/libcrexec/image_score.hpp line 40:
>>
>>> 38: struct Score {
>>> 39: const char* _name;
>>> 40: double _value;
>>
>> Since these are public it would be better not to have a leading underscore
>
> From: https://wiki.openjdk.org/display/HotSpot/StyleGuide#StyleGuide-Names
>
>> Instance variable names start with underscore "_", classes start with upper case letter, local functions are all lower case, all must have meaningful names.
>
> No distinction on public/private
We should "Use public accessor functions for instance variables accessed outside the class" then (the style guide does not differentiate between structs and classes). But ok, let's not complicate the code just to follow the style guide.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/269#discussion_r2454198160
More information about the crac-dev
mailing list