[crac] RFR: 8369566: CRaC: Record metrics during checkpoint [v6]

Radim Vansa rvansa at openjdk.org
Thu Oct 23 09:51:43 UTC 2025


On Thu, 23 Oct 2025 08:43:25 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add license header
>
> src/java.base/share/classes/jdk/internal/crac/mirror/impl/GlobalContext.java line 77:
> 
>> 75:             Score score = new Score(name, ctx);
>> 76:             synchronized (scores) {
>> 77:                 scores.put(name, score);
> 
> Maybe add an assert that this returns null (i.e. the name is new) just in case? Or, since there should be only a single score (for the user global context) maybe the map is redundant?

Hmm, I had two Scores but I've removed the 'inner' one in the end. OK, let's keep this in a single variable...

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/269#discussion_r2454552222


More information about the crac-dev mailing list