[crac] RFR: 8369566: CRaC: Record metrics during checkpoint [v6]
Radim Vansa
rvansa at openjdk.org
Thu Oct 23 09:54:42 UTC 2025
On Thu, 23 Oct 2025 08:46:28 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add license header
>
> src/java.base/share/classes/jdk/internal/crac/mirror/impl/GlobalContext.java line 73:
>
>> 71: // and the context created by jdk.crac.Core (the 'user' global context). We won't record score for
>> 72: // the internal context as if registered here, beforeCheckpoint would be called after Core.Priority.SCORE
>> 73: // and the score would not be recorded.
>
> BTW, it could be useful to count the amount of system-registered resources (recursively, not just the size of the top-level context). Same rationale: more resources => the system is "warmer". But I am not sure the usefulness is great enough to actually implement that.
By system-registered, do you mean `JDKResource` instances? OK, this would be doable (though not recursively, I'd just iterate all Core.Priority contexts).
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/269#discussion_r2454561419
More information about the crac-dev
mailing list