[crac] RFR: 8367975: [CRaC] Pattern in CRaCCheckpointTo
Radim Vansa
rvansa at openjdk.org
Tue Sep 23 12:42:58 UTC 2025
On Tue, 23 Sep 2025 08:58:01 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> Add support for pattern in `CRaCCheckpointTo` VM option.
>
> src/hotspot/share/runtime/crac.cpp line 257:
>
>> 255: #undef check_retval
>> 256:
>> 257: static bool ensure_image_location(const char *path, bool rm) {
>
> Since this is checkpoint-specific:
> Suggestion:
>
> static bool ensure_checkpoint_image_location(const char *path, bool rm) {
>
>
> Or maybe make it also handle the restore case have this in one place.
I don't follow the second part - restore should not attempt to create the directory.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/264#discussion_r2372187587
More information about the crac-dev
mailing list