[crac] RFR: 8367975: [CRaC] Pattern in CRaCCheckpointTo

[Timofei Pushkin]

On Tue, 23 Sep 2025 12:40:06 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> src/hotspot/share/runtime/crac.cpp line 257:
>> 
>>> 255: #undef check_retval
>>> 256: 
>>> 257: static bool ensure_image_location(const char *path, bool rm) {
>> 
>> Since this is checkpoint-specific:
>> Suggestion:
>> 
>> static bool ensure_checkpoint_image_location(const char *path, bool rm) {
>> 
>> 
>> Or maybe make it also handle the restore case have this in one place.
>
> I don't follow the second part - restore should not attempt to create the directory.

Yes, we would need to add a parameters like `bool is_checkpoint` which will define whether we need to create a directory or just check for existence

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/264#discussion_r2372222013