[crac] RFR: 8368570: [CRaC] Improve JdwpTransportTest [v2]

Roman Marchenko rmarchenko at openjdk.org
Mon Sep 29 10:44:15 UTC 2025


On Mon, 29 Sep 2025 09:21:08 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Roman Marchenko has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Update test/lib/jdk/test/lib/crac/CracProcess.java
>>    
>>    fix grammar
>>    
>>    Co-authored-by: Timofei Pushkin <pushkin.td at gmail.com>
>>  - Update test/jdk/jdk/crac/jdwp/JdwpTransportTest.java
>>    
>>    fix copyright
>>    
>>    Co-authored-by: Timofei Pushkin <pushkin.td at gmail.com>
>
> test/jdk/jdk/crac/jdwp/JdwpTransportTest.java line 150:
> 
>> 148:             System.err.println("reader.isRunning()=" + reader.isRunning());
>> 149:             CracProcess.printThreadDump(process.pid());
>> 150:             CracProcess.dumpProcess(process.pid());
> 
> If we end up always taking the PID from `CracProcess` itself why making these two static?

For this test, yes. But these two methods may be useful for tests when Java changes its PID on restore. 

I will change this, if you doesn't think so.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/265#discussion_r2387489336


More information about the crac-dev mailing list