[crac] RFR: 8368570: [CRaC] Improve JdwpTransportTest [v2]

Timofei Pushkin tpushkin at openjdk.org
Mon Sep 29 10:52:39 UTC 2025


On Mon, 29 Sep 2025 10:41:32 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> test/jdk/jdk/crac/jdwp/JdwpTransportTest.java line 150:
>> 
>>> 148:             System.err.println("reader.isRunning()=" + reader.isRunning());
>>> 149:             CracProcess.printThreadDump(process.pid());
>>> 150:             CracProcess.dumpProcess(process.pid());
>> 
>> If we end up always taking the PID from `CracProcess` itself why making these two static?
>
> For this test, yes. But these two methods may be useful for tests when Java changes its PID on restore. 
> 
> I will change this, if you doesn't think so.

I'd make it non-static for now and change to static when/if we need that but I don't insist

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/265#discussion_r2387504794


More information about the crac-dev mailing list