[crac] RFR: 8377173: [CRaC] Don't set direct_map=true on checkpoint

[Timofei Pushkin]

On Thu, 5 Feb 2026 07:16:21 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

> This is a restore-only option, sanity check in the engine might produce warnings/errors.

LGTM but I have a suggestion

src/hotspot/share/runtime/crac_engine.cpp line 185:

> 183:   }
> 184: 
> 185:   if (for_restore && api.can_configure(conf, DIRECT_MAP)) {

We have `CStringSet keys` below that stores all options parsed from `CRaCEngineOptions`. We could move this after the `CRaCEngineOptions` processing to apply only if `DIRECT_MAP` was not in `CRaCEngineOptions`. This way we can avoid providing the option twice — can help against warnings if the engine also performs duplication checking internally.

-------------

PR Review: https://git.openjdk.org/crac/pull/292#pullrequestreview-3755619560
PR Review Comment: https://git.openjdk.org/crac/pull/292#discussion_r2767983044