[crac] RFR: 8377173: [CRaC] Don't set direct_map=true on checkpoint [v2]

[Radim Vansa]

On Thu, 5 Feb 2026 09:33:52 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Avoid configuring direct_map twice
>
> src/hotspot/share/runtime/crac_engine.cpp line 185:
> 
>> 183:   }
>> 184: 
>> 185:   if (for_restore && api.can_configure(conf, DIRECT_MAP)) {
> 
> We have `CStringSet keys` below that stores all options parsed from `CRaCEngineOptions`. We could move this after the `CRaCEngineOptions` processing to apply only if `DIRECT_MAP` was not in `CRaCEngineOptions`. This way we can avoid providing the option twice — can help against warnings if the engine also performs duplication checking internally.

I've moved this, though the change is a bit heavier (can't use the early exit). And I am not even sure if the engine ought to check this - it should be OK to override the configuration couple of times.

I'd be happy to revert the last commit if you see it the same way.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/292#discussion_r2768440744