[crac] RFR: 8377173: [CRaC] Don't set direct_map=true on checkpoint [v2]
Timofei Pushkin
tpushkin at openjdk.org
Thu Feb 5 11:24:32 UTC 2026
On Thu, 5 Feb 2026 11:06:49 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
>> This is a restore-only option, sanity check in the engine might produce warnings/errors.
>
> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>
> Avoid configuring direct_map twice
Marked as reviewed by tpushkin (Committer).
src/hotspot/share/runtime/crac_engine.cpp line 186:
> 184:
> 185: CStringSet keys;
> 186: char* engine_options_start = nullptr;
Does not match the style of the rest of the file, but I don't insist on fixing not to wait more for CI.
Suggestion:
char *engine_options_start = nullptr;
-------------
PR Review: https://git.openjdk.org/crac/pull/292#pullrequestreview-3756348744
PR Review Comment: https://git.openjdk.org/crac/pull/292#discussion_r2768539941
More information about the crac-dev
mailing list