[crac] RFR: 8377173: [CRaC] Don't set direct_map=true on checkpoint [v2]
Radim Vansa
rvansa at openjdk.org
Thu Feb 5 11:58:13 UTC 2026
On Thu, 5 Feb 2026 11:21:53 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:
>> Radim Vansa has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Avoid configuring direct_map twice
>
> src/hotspot/share/runtime/crac_engine.cpp line 186:
>
>> 184:
>> 185: CStringSet keys;
>> 186: char* engine_options_start = nullptr;
>
> Does not match the style of the rest of the file, but I don't insist on fixing not to wait more for CI.
> Suggestion:
>
> char *engine_options_start = nullptr;
While my personal preference is `char *`, we shall probably prefer the style the rest of JDK uses - I took the opportunity.
(I was asked to change the style when filing PRs to upstream)
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/292#discussion_r2768730787
More information about the crac-dev
mailing list