[crac] RFR: 8376959: [CRaC] Turn simengine into shared library [v8]

[Radim Vansa]

On Fri, 6 Feb 2026 08:21:27 GMT, Timofei Pushkin <tpushkin at openjdk.org> wrote:

>> Radim Vansa has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
>> 
>>  - Merge branch 'crac' into simengine_separation
>>  - Fix tests on non-Linux
>>  - Try fix Windows build
>>  - Address review comments
>>  - Fixup
>>  - Fixups
>>  - Implement static build & other platforms
>>  - JDK-8376959: [CRaC] Turn simengine into shared library
>
> src/java.base/share/native/libcrcommon/crcommon.hpp line 83:
> 
>> 81: 
>> 82: extern "C" {
>> 83:   extern CRCOMMON_API const char* log_prefix;
> 
> Nitpick: this looks like it should be a part of `crlib_conf_t`. `LOG` can accept `conf` as parameter — does not seem too bulky. If the conf will be an opaque type then ` const char* log_prefix(const crlib_conf*)` will also be needed.

Architecturally that would fit better, I went for a global variable since it's inconvenient to pass the conf to every static helper function that might error.

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/289#discussion_r2773873443