[crac] RFR: 8376959: [CRaC] Turn simengine into shared library [v8]
Radim Vansa
rvansa at openjdk.org
Mon Feb 9 21:59:17 UTC 2026
On Fri, 6 Feb 2026 12:24:23 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
>> src/java.base/share/native/libcrcommon/crcommon.hpp line 83:
>>
>>> 81:
>>> 82: extern "C" {
>>> 83: extern CRCOMMON_API const char* log_prefix;
>>
>> Nitpick: this looks like it should be a part of `crlib_conf_t`. `LOG` can accept `conf` as parameter — does not seem too bulky. If the conf will be an opaque type then ` const char* log_prefix(const crlib_conf*)` will also be needed.
>
> Architecturally that would fit better, I went for a global variable since it's inconvenient to pass the conf to every static helper function that might error.
I've tried to refactor things but turns out this requires boilerplate, or weird conventions. Let's keep this and the `crlib_conf_t` -> `crcommon_conf_t` global.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/289#discussion_r2774902728
More information about the crac-dev
mailing list