[crac] RFR: 8372933: [CRaC] Restore failed due to incompatible or missing CPU features, try using -XX:CPUFeatures=0xfoo, 0xbar on checkpoint [v2]
Jan Kratochvil
jkratochvil at openjdk.org
Wed Jan 7 20:42:11 UTC 2026
On Wed, 7 Jan 2026 16:15:55 GMT, Radim Vansa <rvansa at openjdk.org> wrote:
>> Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>>
>> - return original prototype of is_failed(), add new get_failed_bitmap()
>> - !EQUALS->SUBSET
>> - conjunction->intersection
>> - Merge branch 'crac' into crac-conjunction
>> - 8372933: [CRaC] Restore failed due to incompatible or missing CPU features, try using -XX:CPUFeatures=0xfoo,0xbar on checkpoint
>
> src/java.base/share/native/libcrexec/image_constraints.hpp line 83:
>
>> 81: const void* data;
>> 82: size_t data_size;
>> 83: const void* intersection; // data_size
>
> I think you can make this just (non-const) `unsigned char *` rather than all the nasty casts when computing the intersection.
I just copycatted the field `data` using similar casts.
-------------
PR Review Comment: https://git.openjdk.org/crac/pull/278#discussion_r2670000071
More information about the crac-dev
mailing list