[crac] RFR: 8372933: [CRaC] Restore failed due to incompatible or missing CPU features, try using -XX:CPUFeatures=0xfoo, 0xbar on checkpoint [v2]

[Jan Kratochvil]

On Wed, 7 Jan 2026 16:21:51 GMT, Radim Vansa <rvansa at openjdk.org> wrote:

>> Jan Kratochvil has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - return original prototype of is_failed(), add new get_failed_bitmap()
>>  - !EQUALS->SUBSET
>>  - conjunction->intersection
>>  - Merge branch 'crac' into crac-conjunction
>>  - 8372933: [CRaC] Restore failed due to incompatible or missing CPU features, try using -XX:CPUFeatures=0xfoo,0xbar on checkpoint
>
> src/hotspot/share/include/crlib/crlib_image_constraints.h line 67:
> 
>> 65:   bool (*is_failed)(crlib_conf_t *, const char *name);
>> 66: 
>> 67:   // For failed require_bitmap it will copy the expected value to the provided buffer.
> 
> I would expect this function to return the stored bitmap value (and you'd calculate the intersection only in the caller). If you want to use the current semantics please elaborate in the docs what is the 'expected value' for each of the `crlib_bitmap_comparison_t`.

Addressed by: https://github.com/openjdk/crac/pull/278/changes/69b9686bfb41d29762e02f7e3caf74237e8f3e18

-------------

PR Review Comment: https://git.openjdk.org/crac/pull/278#discussion_r2749514098