OpenJDK Community Code Review server rollout

Tim Bell Tim.Bell at Sun.COM
Thu Mar 5 01:52:24 UTC 2009

[Moving this thread to web-discuss (at)]

John Rose wrote:

> Thanks!  A couple of RFEs:

Thanks back.  BTW - I owe a lot to Dan Price and the OpenSolaris folks 
for working out this code review server scheme - what I did was take 
their layout and hook it up with our db.ojn server and authentication 
scheme.  After we got a bunch of Legal approval and other 
non-programming issues settled...

> You mention webrev on the root page; can we have a link to it there, as 
> there in your rollout Email?

Yes, I will make that information more prominent on the page later 
tonight.  Jessie (Jean-Christophe Collet) has been doing good work on 
the webrev script lately, so you probably want to be running the latest 

> The webrevs are not very portable in their expanded browsable state:  
> There are too many files.  I'd like to see an option to upload or 
> download a *tgz or *zip bundle as a unit.
> It could be fairly simple, with just one bit of magic:  Have a private 
> ".bundles" subdirectory hierarchy with a background script watching it, 
> like ".trashes".  Uploading to ".bundles" would cause the archive file 
> to be unpacked (relative to top level).  Allow both ".bundles" "bundles" 
> (w/ & w/o leading dot) also, so that the archive files themselves could 
> be left out in public, for easy anonymous downloading.

Good idea, and not so hard to set up.  Does anyone else have an opinion 
on this feature?  I will work on getting this up later this week.

Thanks for the feedback-


> P.S.  The old site did not supply 
> rsync/scp/sftp, so I forced users to upload single *tgz or *zip files 
> manually.  The virtue of this necessity was that the server uploaded the 
> bundles as a unit and then unpacked them locally, saving lots of network 
> handshakes.

Yes, that is true, although I don't notice a real bottleneck with the 
network.  I typically start up a 'scp -r' and then go heat up some water 
for tea...

More information about the discuss mailing list