New candidate JEP: 357: Migrate from Mercurial to Git

[Andrew Dinn]

Personally, I am quite happy with this change to a different SCM
implementation. Nevertheless, I agree with Aleksey's criticism that the
JEP does not adequately assess potential negative effects of this change.

Anyway, I'm not replying with the intention of hammering on that point,
rather to flag what looks like a grammatical error (sic ;-) in the
Description section. It says:

  . . .
  Trailers : BlankLine Co-authors? Reviewers
  Co-authors : (BlankLine Co-author )+
  Co-author : "Co-authored-by: " Real-name <Email>
  Reviewers : "Reviewed-by: " Username (", " Username)* "\n"
  BlankLine = "\n"

This appears to require that all (optional) co-author attributions
precede all reviewer attributions? If so then the example text that
follows is at odds with this requirement:

  . . .
  Fixed a tricky race condition when the JVM is starting up by using a
Mutex.

  Reviewed-by: darcy
  Co-authored-by: Robin Westberg <rwestberg at openjdk.org>

Of course, the error may be in the grammar itself not the example . . .

regards,


Andrew Dinn
-----------