Contributing various small OpenJDK fixes: IKVM

[David Holmes]

On 20/07/2024 12:45 am, Aleksey Shipilev wrote:
> Hi,
> 
> On 19.07.24 16:35, Jerome Haltom wrote:
>> I would like to get some of these changes into upstream. Are these the 
>> types of changes that might be acceptable to upstream? This seemed 
>> like a good place for me to start with this discussion. At the end of 
>> the day, they are mostly minor changes fixing various minor 
>> compilation issues with Clang. 
> 
> Yes, simple build fixes are almost always welcome.
> 
> There are rare occasions when a change poses a risk to builds on common 
> configurations. Another possible point of contention might be doing 
> considerable rewrites to accommodate unusual build configurations. The 
> benefits for those should generally outweigh the maintenance burden.
> 
>  From experience, builds often need a few light touches here and there, 
> so these risks might never actually materialize as blockers. Feel free 
> to submit PRs against openjdk/jdk and see where it goes.

But Jerome indicated he needs to target 8u. It would be impractical to 
propose fixes against mainline and then try to backport all the way to 8u.

This should really be raised with the 8u maintainers on 
jdk8u-dev at openjdk.org

Cheers,
David

> -Aleksey
> 
> 
> 
> Amazon Web Services Development Center Germany GmbH
> Krausenstr. 38
> 10117 Berlin
> Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
> Eingetragen am Amtsgericht Charlottenburg unter HRB 257764 B
> Sitz: Berlin
> Ust-ID: DE 365 538 597