Support BSD and Caciocavallo

[Andrew John Hughes]

On 31/08/2008, Mark Wielaard <mark at klomp.org> wrote:
> Hi Andrew,
>
>
>  On Sat, 2008-08-30 at 02:39 +0100, Andrew John Hughes wrote:
>  > This patch adds support for downloading the BSD and Caciocavallo trees
>  > to IcedTea.
>  > You can choose a project using --with-project and a value of jdk7 (the
>  > default), closures, cvmi, caciocavallo and bsd to select a tree.
>
>
> Heay, that is super cool!
>
>

:)

>  > It currently only makes
>  > a difference if you also add --enable-hg; the two are separated so
>  > additional project-specific rules can be added.
>
>
> I immediately fell into the "--enable-hg trap" by forgetting it. I think
>  it makes sense to either make that the default if --with-project=x is
>  given and project x needs a hg repo pull, or at least fail the
>  configure/build step.
>

Attached patch fixes this:

2008-08-31  Andrew John Hughes  <gnu_andrew at member.fsf.org>

	* Makefile.am:
	Make enabling hg-only projects sufficient for
	downloading from hg.

This does mean I had to separate out the hg forest check so it wasn't
duplicated.

>
>  >   I tried building the
>  > caciocavallo and closures trees but the IcedTea patches need some work
>  > to apply cleanly (presumably because these trees are based on older
>  > build drops).
>
>
> Yeah, this might be a bit of a pain to keep current. Either the projects
>  supported need to sync often enough or we need to differentiate our
>  patches. Neither is really that attractive. The best thing would
>  probably be for us to help these projects get pushed into the main jdk7
>  tree sooner.
>

Some patches are more prone to this than others, or, in other words, there are
some patches that break with just about every build drop as well.
I'll try and clean
some of them up so they are less prone to this.  Notably, I think most
of patches/icedtea-copy-plugs.patch should be part of
icedtea-ecj.patch and the rest should be dropped.  It would also be
nice to split up icedtea-ecj as it covers a lot of issues at present,
for which the only relationship is that they fix breakages that only
occur with an ecj + GNU Classpath build.

>
>  > 2008-08-30  Andrew John Hughes  <gnu_andrew at member.fsf.org>
>  >
>  >       * Makefile.am: Add BSD and Caciocavallo URLs.
>  >       * acinclude.m4:
>  >       (WITH_PROJECT): Added.
>  >       (ENABLE_OTHER_PROJECTS): Converted to WITH_PROJECT.
>  >       * configure.ac: Support building with BSD
>  >       and Caciocavallo projects via --with-project.
>  >
>  > Note that jdk7 is now finally at b33, just as b34 comes out...
>
>
> You managed to push this without generating a commit message. I cannot
>  figure out why that is. Do you have any idea how you got this commit in
>  "under the hgext.notify radar"?
>

Something is broken:

remote: added 1 changesets with 2 changes to 2 files
remote: error: incoming.notify hook raised an exception: cannot
concatenate 'str' and 'NoneType' objects

But at least it means merges are quiet ;)

>  Cheers,
>
>
>  Mark
>
>


-- 
Andrew :-)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: no_enable_hg.diff
Url: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20080831/5b74448a/no_enable_hg.diff