Support BSD and Caciocavallo

C. K. Jester-Young cky944 at gmail.com
Sun Aug 31 22:50:58 PDT 2008


Hi Andrew,

On Sun, Aug 31, 2008 at 09:01:56PM +0100, Andrew John Hughes wrote:
> 2008-08-31  Andrew John Hughes  <gnu_andrew at member.fsf.org>
> 
> 	* Makefile.am:
> 	Make enabling hg-only projects sufficient for
> 	downloading from hg.
> 
> This does mean I had to separate out the hg forest check so it wasn't
> duplicated.

I like the idea of the fix, though I think the way it's implemented
doesn't do what's intended, and is additionally a maintenance hassle
whenever new Mercurial repositories are added.

Looking at the forest test, it only applies if !OPENJDK_SRC_DIR_FOUND
&& !USE_ALT_OPENJDK_SRC_ZIP && USE_HG && USE_CLOSURES && USE_CVMI &&
USE_CACIOCAVALLO && USE_BSD. In other words, this test will never be
invoked.

I propose an alternative patch, that simply turns --enable-hg on if
--with-project != jdk7. The main caveat is now that the --with-project
stuff must appear before the --enable-hg. But other than that, I think
that this is more robust and easier to maintain, and I hope it works
for you too. :-)

Many thanks,
	---Chris K.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icedtea-implicit-enable-hg.diff
Type: text/x-diff
Size: 685 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20080901/c503d6d2/icedtea-implicit-enable-hg.diff 


More information about the distro-pkg-dev mailing list