RFC: Only enable NIO2 by default when building with IcedTea

Andrew John Hughes gnu_andrew at member.fsf.org
Tue Feb 10 11:07:26 PST 2009


It appears that some older versions of ecj fail when building the 
NIO2 code:

1. ERROR in ../../../src/share/classes/org/classpath/icedtea/java/nio/file/spi/AbstractPath.java (at line 276)
   public final WatchKey register(WatchService watcher, WatchEvent.Kind<?>... events)
        throws IOException
	                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Name clash: The method register(WatchService, WatchEvent.Kind<?>...) of type AbstractPath has the same erasure as register(WatchService, WatchEvent.Kind<?>...) of type Watchable but does not override it
----------

It looks like this bug:

https://bugs.eclipse.org/bugs/show_bug.cgi?id=243820

The attached patch sets the NIO2 default based on whether with_icedtea is enabled.  So this works,
and to be consistent with the rest of the autotools macro, it switches the values used from true/false
to yes/no.

Okay to commit?

ChangeLog:

2009-02-10  Andrew John Hughes  <ahughes at redhat.com>

	* Makefile.am:
	Only build NIO2 by default if building with
	IcedTea.  Fix with_icedtea/with_openjdk to use
	yes/no rather than true/false.

-- 
Andrew :)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8
-------------- next part --------------
diff -r c402774cf211 configure.ac
--- a/configure.ac	Sun Feb 08 08:33:04 2009 -0500
+++ b/configure.ac	Tue Feb 10 18:59:30 2009 +0000
@@ -44,15 +44,15 @@
         [
           if test "x${withval}" != xno
           then
-            with_icedtea=true
+            with_icedtea=yes
           else
-            with_icedtea=false
+            with_icedtea=no
           fi
         ],
         [
-          with_icedtea=false
+          with_icedtea=no
         ])
-AM_CONDITIONAL(WITH_ICEDTEA, test "${with_icedtea}" = true)
+AM_CONDITIONAL(WITH_ICEDTEA, test "${with_icedtea}" = yes)
 AC_MSG_RESULT(${with_icedtea})
 
 AC_MSG_CHECKING([whether to build using an existing installation of OpenJDK])
@@ -62,15 +62,15 @@
         [
           if test "x${withval}" != xno
           then
-            with_openjdk=true
+            with_openjdk=yes
           else
-            with_openjdk=false
+            with_openjdk=no
           fi
         ],
         [
-          with_openjdk=false
+          with_openjdk=no
         ])
-AM_CONDITIONAL(WITH_OPENJDK, test "${with_openjdk}" = true)
+AM_CONDITIONAL(WITH_OPENJDK, test "${with_openjdk}" = yes)
 AC_MSG_RESULT(${with_openjdk})
 
 AC_MSG_CHECKING(for Ant home directory)
@@ -135,7 +135,7 @@
 AC_ARG_ENABLE([nio2],
 	      [AS_HELP_STRING([--disable-nio2],
 	      		      [Disable inclusion of backported NIO2])],
-	      [ENABLE_XRENDER="${enableval}"], [ENABLE_NIO2='yes'])
+	      [ENABLE_NIO2="${enableval}"], [ENABLE_NIO2="${with_icedtea}"])
 AM_CONDITIONAL([ENABLE_NIO2], [test x$ENABLE_NIO2 = xyes])
 AC_MSG_RESULT(${ENABLE_NIO2})
 
@@ -183,7 +183,7 @@
 SET_ARCH_DIRS
 SET_OS_DIRS
 
-if test "${with_openjdk}" = true
+if test "${with_openjdk}" = yes
 then
   AC_CHECK_FOR_OPENJDK
   JAVA=$SYSTEM_OPENJDK_DIR/bin/java
@@ -197,7 +197,7 @@
   RMIC=${SYSTEM_OPENJDK_DIR}/bin/rmic
   AC_SUBST(RMIC)
 else
-if test "${with_icedtea}" = true
+if test "${with_icedtea}" = yes
 then
   AC_CHECK_FOR_ICEDTEA
   JAVA=$SYSTEM_ICEDTEA_DIR/bin/java


More information about the distro-pkg-dev mailing list