BSD Port and Linux Differences

[Michael Franz]

I did not find any other issues when trying to compile the bsd port on
Fedora using IcedTea7.

The statfs vs statvfs has already been addressed by Greg. Thanks!

The strncpy vs strlcpy was also addressed by Greg.  I have attached an
alternative patch that keeps TimeZone_md.c closer to the linux version.  It
uses the typo fixes from the bsd-port..  This basically reverts the bsd
version back to the linux version.

I have attached the machine/endian.h patches too.  Greg's comments can be
found here
http://mail.openjdk.java.net/pipermail/bsd-port-dev/2009-February/000512.html

With these patches I:
1. changed the fuzz level from 0 to 3 (reduces the number of patches I
needed to deal with)
2. removed the parts of the icedtea patches that failed.
3. manually changed the source files affected by the attached patches
4. manually applied patches to fix splashscreen and jsound makefiles.

Next, I plan to create patch files for the splashscreen and jsound makefiles
(this was stuff that did not apply and was removed).

The following patches had sections/files removed.
M patches/hotspot/original/icedtea-includedb.patch
M patches/icedtea-jsoundhs.patch
M patches/icedtea-libraries.patch
M patches/icedtea-linker-libs-order.patch

java -version
IcedTea 1.9-pre-r70396cb4abf8 Runtime Environment (build 1.7.0_0-bsd-b44)
OpenJDK Server VM (build 14.0-b10, mixed mode)

Michael


On Wed, Feb 11, 2009 at 12:13 AM, Greg Lewis <glewis at eyesbeyond.com> wrote:

> On Tue, Feb 10, 2009 at 11:00:35AM -0500, Christos Zoulas wrote:
> > On Feb 9,  7:56pm, mvfranz at gmail.com (Michael Franz) wrote:
> > -- Subject: BSD Port and Linux Differences
> >
> > | Hi,
> > |
> > | I am still working through the issues to get the bsd-port repo to
> compile on
> > | Linux and have run into these issues.
> > |
> > | BSD is using statfs instead of statvfs.  Both are available on Linux
> and OS
> > | X.  The difference is how they are included.  Linux uses either
> sys/statfs.h
> > | or sys/statfs.h while OS X (and I assume other BSDs) are use
> > | sys/param.h,sys/mount.h or sys/statvfs.h.  See
> > | jdk/src/solaris/native/java/io/UnixFileSystem_md.c for more details.
> >
> > NetBSD uses statvfs too.
> >
> > | Is it better to use one over the other?  Do we really want to use
> statfs on
> > | bsd and statvfs on linux?
> >
> > statvfs should be preferred over statfs because:
> > 1. it is part of POSIX:
> >     http://www.opengroup.org/onlinepubs/009695399/functions/statvfs.html
> > 2. it is newer and has 64 bit fields where appropriate (in most
> implementations)
> >
> > I think we need some #ifdef's there to handle which include is
> appropriate
> > for which OS.
>
> It looks like everything supports statvfs now, so I don't think we need
> any #ifdef's at all.  I've got a patch to revert this change.
>
> > | I have run into a similar issue with strncpy vs strlcpy.  The bsd port
> is
> > | using strlcpy, as far as I can tell, strlcpy does not exist on linux.
>  Both
> > | have strncpy, should this be used instead?
> > |
> > | This issue exists in jdk/src/solaris/native/java/util/TimeZone_md.c
> >
> > strl{cpy,cat} should be preferred over strn{cpy,cat}. If that is the only
> > use though, I say put it back to use strncpy() correctly, since java
> probably
> > uses strn{cpy,cat} all over the place and providing portability just for
> > one use is overkill.
>
> *sigh* It looks like the GNU libc maintainers don't like strlcpy, so
> although *BSD and Solaris have it, Linux does not.  I'll change it to
> strncpy universally rather than adding an #ifdef just for that.
>
> > | A previous difference that I have found was in the use of
> machine/endian.h
> > | in the BSD port.
> >
> > This is a more complicated :-) and I will let someone else answer it.
>
> I've already answered this before :).  Its the right thing to do.  We
> just need to also do the right thing for Linux and Solaris.
>
> I've got access to an Ubuntu box -- I can try a compile there as well.
>
> --
> Greg Lewis                          Email   : glewis at eyesbeyond.com
> Eyes Beyond                         Web     : http://www.eyesbeyond.com
> Information Technology              FreeBSD : glewis at FreeBSD.org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090212/0243d39a/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bsd-strncpy-changes-for-linux-build.diff
Type: application/octet-stream
Size: 1646 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090212/0243d39a/bsd-strncpy-changes-for-linux-build.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bsd-endian-changes-for-linux-build.diff
Type: application/octet-stream
Size: 1366 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090212/0243d39a/bsd-endian-changes-for-linux-build.diff