FYI: Fix typo in configure.ac

Andrew John Hughes gnu_andrew at member.fsf.org
Thu Feb 12 08:14:49 PST 2009


2009/2/12 Matthias Klose <doko at ubuntu.com>:
> Andrew John Hughes schrieb:
>> Fixing a typo which prevents NIO2 being disabled... :(
>>
>> ChangeLog:
>>
>> 2009-02-12  Andrew John Hughes  <ahughes at redhat.com>
>>
>>       * configure.ac:
>>       Fix typo in --enable-nio2.
>
> maybe we should disable nio2 by default on all archs except amd64 and ix86.  It
> currently builds on other archs, but the vm crashes on the first test in the
> jtreg testsuite. The code itself has comments inside UnixNativeDispatcher.c that
> it doesn't work on anything else.
>

Does it crash if fstats64 is actually used rather than being taken out
and replaced by a hack through the #defined(__linux__) stuff?

> The code continues to hardcode the use of functions (here fstatat) based on
> experience from the coder (#if defined(__linux__) ...). The assertion is not
> enough. You seem to need a recent glibc as well. How could upstream be convinced
> to use autoconf checks (AC_CHECK_FUNC) and use these instead?
>

I was wondering this too -- maybe a reason to push them to have an
autoconf wrapper? :D

>  Matthias
>
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8



More information about the distro-pkg-dev mailing list