FYI: Fix typo in configure.ac

Joseph D. Darcy Joe.Darcy at Sun.COM
Fri Feb 13 13:36:08 PST 2009


Hello.

Matthias Klose wrote:
> Andrew John Hughes schrieb:
>   
>> Fixing a typo which prevents NIO2 being disabled... :(
>>
>> ChangeLog:
>>
>> 2009-02-12  Andrew John Hughes  <ahughes at redhat.com>
>>
>> 	* configure.ac:
>> 	Fix typo in --enable-nio2.
>>     
>
> maybe we should disable nio2 by default on all archs except amd64 and ix86.  It
> currently builds on other archs, but the vm crashes on the first test in the
> jtreg testsuite. The code itself has comments inside UnixNativeDispatcher.c that
> it doesn't work on anything else.
>
> The code continues to hardcode the use of functions (here fstatat) based on
> experience from the coder (#if defined(__linux__) ...). The assertion is not
> enough. You seem to need a recent glibc as well. How could upstream be convinced
> to use autoconf checks (AC_CHECK_FUNC) and use these instead?
>
>   Matthias
>
>   

Alan Bateman is the right upstream person to talk to for nio2 issues.

Kelly and Mark R. should be involved in any discussions about changing 
the fundamental build infrastructure to use autoconf or other techniques 
than what are currently being used.  Patches to update the upstream code 
base to use new techniques wouldn't hurt the chances of the new 
techniques being adopted :-)

Note that besides Linux, the OpenJDK build also needs to work well on 
Solaris and windows.

-Joe




More information about the distro-pkg-dev mailing list