IcedTea7 Zero/Shark build patch

Gary Benson gbenson at redhat.com
Mon Nov 16 10:07:40 PST 2009


Andrew John Hughes wrote:
> 2009/11/16 Matthias Klose <doko at ubuntu.com>:
> > On 16.11.2009 11:31, Gary Benson wrote:
> > > Zero (and Shark) require different build variables to be set for
> > > the upstream Zero than the ones we've currently been using.
> > > This patch should fix the way these are set.  I haven't tested
> > > this with Cacao, or with the build-multiple-vms-at-once that
> > > doko contributed.  Is this ok to commit?
> >
> > not able to test this now; will check with a future build.
> 
> This doesn't do what you say it does; it just makes the addition of
> the environment variables conditional on zero and/or shark being
> turned on.  The actual environment variables are identical.  I don't
> see a benefit to that, but I do see a risk in something being broken
> so I don't want it applied just before a release.

Hmmm, you're right, I didn't see your ARCH_DATA_MODEL patch.  I made
the variables only be set for Zero builds because ARCH_DATA_MODEL has
meaning for non-Zero builds, so setting ARCH_DATA_MODEL always could
cause non-Zero builds to suddenly break.

Cheers,
Gary

-- 
http://gbenson.net/



More information about the distro-pkg-dev mailing list