IcedTea7 Zero/Shark build patch

[Andrew John Hughes]

2009/11/16 Gary Benson <gbenson at redhat.com>:
> Andrew John Hughes wrote:
>> 2009/11/16 Matthias Klose <doko at ubuntu.com>:
>> > On 16.11.2009 11:31, Gary Benson wrote:
>> > > Zero (and Shark) require different build variables to be set for
>> > > the upstream Zero than the ones we've currently been using.
>> > > This patch should fix the way these are set.  I haven't tested
>> > > this with Cacao, or with the build-multiple-vms-at-once that
>> > > doko contributed.  Is this ok to commit?
>> >
>> > not able to test this now; will check with a future build.
>>
>> This doesn't do what you say it does; it just makes the addition of
>> the environment variables conditional on zero and/or shark being
>> turned on.  The actual environment variables are identical.  I don't
>> see a benefit to that, but I do see a risk in something being broken
>> so I don't want it applied just before a release.
>
> Hmmm, you're right, I didn't see your ARCH_DATA_MODEL patch.  I made
> the variables only be set for Zero builds because ARCH_DATA_MODEL has
> meaning for non-Zero builds, so setting ARCH_DATA_MODEL always could
> cause non-Zero builds to suddenly break.
>
> Cheers,
> Gary
>
> --
> http://gbenson.net/
>

Yes, I fixed that:

        * acinclude.m4:
        (ENABLE_ZERO_BUILD): Always set ZERO flags so that ARCH_DATA_MODEL
        is not set empty.

So the Zero flags are always set and just ZERO_BUILD determines
whether they are used or not.
I did think of doing the same thing as your patch after I'd done that,
but I think it makes things easier if all the variables used are
always set.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8