Request to push: Port libjpeg fix from icedtea6 to icedtea

[Andrew John Hughes]

On 29 April 2010 22:00,  <jon.vanalten at redhat.com> wrote:
> Diff of *correct* fix, attached.
>
> jon
>
>
> ----- "Jon VanAlten" <jon.vanalten at redhat.com> wrote:
>
>> Urp, thanks and you're right... I based this on browsing repo via
>> http, didn't realize I was in an older revision...  Better port to
>> follow.
>>
>>
>> ----- "Matthias Klose" <doko at ubuntu.com> wrote:
>>
>> > On 29.04.2010 20:59, jon.vanalten at redhat.com wrote:
>> > > Hi,
>> > >
>> > > The attached diff ports the fix for
>> > http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=367 to
>> icedtea,
>> > as suggested in
>> > http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=442
>> > >
>> > > OK to push?
>> >
>> > didn't we revert this patch? IMO it's only safe to use the jpeg
>> > version that
>> > openjdk was built with.
>> >
>> >    Matthias
>

This patch looks horribly broken, there are numerous diff segments
with no changes.

When forwardporting, the original changesets should preferably be used:

changeset:   1841:fcd85ef6c2ae
user:        Andrew John Hughes <ahughes at redhat.com>
date:        Mon Jan 25 15:35:21 2010 +0000
summary:     Support libjpeg8 and always choose the dlopen invocation
at build time.

changeset:   1818:8577904b8e6f
user:        Andrew John Hughes <ahughes at redhat.com>
date:        Mon Jan 11 20:12:43 2010 +0000
summary:     Decide on libjpeg library at compile-time not runtime.

The current plan for IcedTea7 is to:

* Bump to b89
* Review and forwardport all appropriate IcedTea6 patches to 7
* Release 1.13

and I'd prefer this fix was added as part of that process rather than
this patch being applied.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8