[RFC] netx: add 1.6 to supported jnlp versions

Omair Majid omajid at redhat.com
Tue Aug 10 06:59:12 PDT 2010


On 08/09/2010 05:58 PM, Dr Andrew John Hughes wrote:
> On 11:21 Mon 09 Aug     , Deepak Bhole wrote:
>> * Omair Majid<omajid at redhat.com>  [2010-08-09 11:08]:
>>> Hi,
>>>
>>> Some webstart applications like JForex [1] claim to use version 1.6
>>> of the jnlp specification, even though it is not listed in the
>>> developers guide [2]: "The spec attribute can be 1.0, 1.5.0, or 6.0
>>> or can use the wildcards such as 1.0+."
>>>
>>> The attached patch make netx work with a version of 1.6 as well.
>>>
>>> Ok to commit?
>>>
>>> Cheers,
>>> Omair
>>>
>>>
>>> [1] https://www.dukascopy.com/client/demo/jclient/jforex.jnlp
>>> [2]http://download.oracle.com/javase/6/docs/technotes/guides/javaws/developersguide/syntax.html
>>
>>> diff -r a570f4fed326 netx/net/sourceforge/jnlp/Parser.java
>>> --- a/netx/net/sourceforge/jnlp/Parser.java	Fri Aug 06 20:08:18 2010 +0100
>>> +++ b/netx/net/sourceforge/jnlp/Parser.java	Mon Aug 09 10:57:48 2010 -0400
>>> @@ -72,7 +72,7 @@
>>>
>>>
>>>       /** the supported JNLP file versions */
>>> -    private static Version supportedVersions = new Version("1.0 1.5 6.0");
>>> +    private static Version supportedVersions = new Version("1.0 1.5 1.6 6.0");
>>>
>>>       // fix: some descriptors need to use the jnlp file at a later
>>>       // date and having file ref lets us pass it to their
>>
>>
>>
>> Okay to commit to 1.7, 1.8 and HEAD.
>>
>> Cheers,
>> Deepak
>
> And 1.9.  Though Omair did this anyway.

Well, I assumed that if a fix is good enough for 1.7, 1.8 and HEAD, it 
is good enough for 1.9 :)

Cheers,
Omair



More information about the distro-pkg-dev mailing list