[RFC] netx: add 1.6 to supported jnlp versions

[Dr Andrew John Hughes]

On 09:59 Tue 10 Aug     , Omair Majid wrote:
> On 08/09/2010 05:58 PM, Dr Andrew John Hughes wrote:
> > On 11:21 Mon 09 Aug     , Deepak Bhole wrote:
> >> * Omair Majid<omajid at redhat.com>  [2010-08-09 11:08]:
> >>> Hi,
> >>>
> >>> Some webstart applications like JForex [1] claim to use version 1.6
> >>> of the jnlp specification, even though it is not listed in the
> >>> developers guide [2]: "The spec attribute can be 1.0, 1.5.0, or 6.0
> >>> or can use the wildcards such as 1.0+."
> >>>
> >>> The attached patch make netx work with a version of 1.6 as well.
> >>>
> >>> Ok to commit?
> >>>
> >>> Cheers,
> >>> Omair
> >>>
> >>>
> >>> [1] https://www.dukascopy.com/client/demo/jclient/jforex.jnlp
> >>> [2]http://download.oracle.com/javase/6/docs/technotes/guides/javaws/developersguide/syntax.html
> >>
> >>> diff -r a570f4fed326 netx/net/sourceforge/jnlp/Parser.java
> >>> --- a/netx/net/sourceforge/jnlp/Parser.java	Fri Aug 06 20:08:18 2010 +0100
> >>> +++ b/netx/net/sourceforge/jnlp/Parser.java	Mon Aug 09 10:57:48 2010 -0400
> >>> @@ -72,7 +72,7 @@
> >>>
> >>>
> >>>       /** the supported JNLP file versions */
> >>> -    private static Version supportedVersions = new Version("1.0 1.5 6.0");
> >>> +    private static Version supportedVersions = new Version("1.0 1.5 1.6 6.0");
> >>>
> >>>       // fix: some descriptors need to use the jnlp file at a later
> >>>       // date and having file ref lets us pass it to their
> >>
> >>
> >>
> >> Okay to commit to 1.7, 1.8 and HEAD.
> >>
> >> Cheers,
> >> Deepak
> >
> > And 1.9.  Though Omair did this anyway.
> 
> Well, I assumed that if a fix is good enough for 1.7, 1.8 and HEAD, it 
> is good enough for 1.9 :)
> 

Yeah, exactly :-) The note was more to remind Deepak that there's an
additional branch to consider now...

> Cheers,
> Omair

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8