[icedtea-web] RFC: Solution for IcedTea7 build issues

[Andrew Su]

On 12/14/2010 08:32 AM, Dr Andrew John Hughes wrote:
> So I was right; IcedTea7 exports a completely different set of symbols from libjli:
>
> $ diff -u ../upstream/{jdk6,icedtea}/jdk/make/java/jli/mapfile-vers
>
> --- ../upstream/jdk6/jdk/make/java/jli/mapfile-vers	2010-10-15 13:07:37.811943470 +0100
> +++ ../upstream/icedtea/jdk/make/java/jli/mapfile-vers	2010-11-10 21:10:25.515773511 +0000
> @@ -1,5 +1,5 @@
>   #
> -# Copyright (c) 2005, 2006, Oracle and/or its affiliates. All rights reserved.
> +# Copyright (c) 2005, 2008, Oracle and/or its affiliates. All rights reserved.
>   # DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   #
>   # This code is free software; you can redistribute it and/or modify it
> @@ -27,20 +27,13 @@
>
>   SUNWprivate_1.1 {
>   	global:
> -		JLI_ParseManifest;
> -		JLI_JarUnpackFile;
> -		JLI_FreeManifest;
> +		JLI_Launch;
>   		JLI_ManifestIterate;
> -		JLI_ExactVersionId;
> -		JLI_PrefixVersionId;
> -		JLI_AcceptableRelease;
> -		JLI_ValidVersionString;
> -		JLI_WildcardExpandClasspath;
> -		JLI_MemAlloc;
> -		JLI_MemRealloc;
> -		JLI_StringDup;
> -		JLI_MemFree;
> -
> +		JLI_SetTraceLauncher;
> +		JLI_ReportErrorMessage;
> +		JLI_ReportErrorMessageSys;
> +		JLI_ReportMessage;
> +		JLI_ReportExceptionDescription;
>   	local:
>   		*;
>   };
>
> The simplest way to fix this is to make our launchers independent of libjli.  This puts us more
> in control, means we can make local fixes rather than being reliant on the JDK IcedTea-Web is
> built against and also makes it more feasible to support JDKs without libjli (any non-Oracle
> JDK I would imagine such as gcj) in the future.
>
> Here's a patch to do that (against 1.0):
>
> 2010-12-14  Andrew John Hughes<ahughes at redhat.com>
>
> 	* Makefile.am:
> 	(LAUNCHER_OBJECTS): Add jli_util.o, parse_manifest.o,
> 	version_comp.o, wildcard.o.
> 	(LAUNCEHR_FLAGS): Add -DEXPAND_CLASSPATH_WILDCARDS
> 	as used in build of libjli in OpenJDK.
> 	(LAUNCHER_LINK): Don't link to libjli.
> 	* launcher/jli_util.c,
> 	* launcher/parse_manifest.c,
> 	* launcher/version_comp.c,
> 	* launcher/wildcard.c:
> 	Add source files from OpenJDK6 to match header files
> 	already used.
>
> This allows IcedTea-Web to be built against both IcedTea6 and IcedTea7.
>
> Ok for 1.0 and trunk?
>
> I still can't run the javaws or itweb-settings binaries with IcedTea7:
>
> $ /home/andrew/build/icedtea7/bin/javaws -about
> Exception in thread "main" java.lang.NoClassDefFoundError: net/sourceforge/jnlp/runtime/Boot
> Caused by: java.lang.ClassNotFoundException: net.sourceforge.jnlp.runtime.Boot
>
> I presume this is because IcedTea7 hasn't been patched to look for netx.jar and plugin.jar.  Do
> we want to patch this in or do we have a better solution?
>
> Also I noticed a couple of issues running the binaries:
>
> * itweb-settings:
>    - The text in the about tab, 'Currently does not support multiple JRE' should be 'The use of multiple JREs is currently unsupported.'
>      The similar text in the Runtimes tab should be 'IcedTea-Web currently does not support the use of multiple JREs'.
Hi Andrew,

I have attached a patch to change the text to your suggestions.

Ok for commit?

Cheers,
   Andrew

> * NetX about applet:
>    - We only credit Jon Maxwell and Joshua Sumali.  There should be more.  You may also want to consider whether or not to keep the sourceforge link.
>
> These should be fixed for 1.0.
>
> Longer term, how are things like itweb-settings obtaining the product name and version? Are these hardcoded?
> They should be provided by configure in 1.1.
>
> Thanks,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20101214_changed_jre_support_and_info.patch
Type: text/x-patch
Size: 1047 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20101214/2c50a46c/20101214_changed_jre_support_and_info.patch