[icedtea-web] RFC: Solution for IcedTea7 build issues

Dr Andrew John Hughes ahughes at redhat.com
Tue Dec 14 15:44:11 PST 2010


On 10:46 Tue 14 Dec     , Andrew Su wrote:
snip...
> > Also I noticed a couple of issues running the binaries:
> >
> > * itweb-settings:
> >    - The text in the about tab, 'Currently does not support multiple JRE' should be 'The use of multiple JREs is currently unsupported.'
> >      The similar text in the Runtimes tab should be 'IcedTea-Web currently does not support the use of multiple JREs'.
> Hi Andrew,
> 
> I have attached a patch to change the text to your suggestions.
> 
> Ok for commit?
> 

Woah, that was fast :-)

I think 'does not currently' would sound better than 'currently does not' in the second one (my bad).
Otherwise good to commit and thanks for fixing.

> Cheers,
>    Andrew
> 
> > * NetX about applet:
> >    - We only credit Jon Maxwell and Joshua Sumali.  There should be more.  You may also want to consider whether or not to keep the sourceforge link.
> >
> > These should be fixed for 1.0.
> >
> > Longer term, how are things like itweb-settings obtaining the product name and version? Are these hardcoded?
> > They should be provided by configure in 1.1.
> >
> > Thanks,
> 

> diff -r adef5d4159ee netx/net/sourceforge/jnlp/resources/Messages.properties
> --- a/netx/net/sourceforge/jnlp/resources/Messages.properties	Mon Dec 13 17:28:01 2010 -0500
> +++ b/netx/net/sourceforge/jnlp/resources/Messages.properties	Tue Dec 14 10:39:36 2010 -0500
> @@ -284,7 +284,7 @@
>  CPTabSecurity=Security
>  
>  # Control Panel - AboutPanel
> -CPAboutInfo=This is the control panel for setting deployments.properties.<br/>Not all options will take effect until implemented.<br/>Currently does not support multiple JRE.<br/>
> +CPAboutInfo=This is the control panel for setting deployments.properties.<br/>Not all options will take effect until implemented.<br/>The use of multiple JREs is currently unsupported.<br/>
>  
>  # Control Panel - AdvancedProxySettings
>  APSDialogTitle=Network Settings
> @@ -365,7 +365,7 @@
>  TIFPRestoreDefaults=Restore defaults
>  
>  # Control Panel - Misc.
> -CPJRESupport=Icedtea-web currently does not support multiple JRE.
> +CPJRESupport=IcedTea-Web currently does not support the use of multiple JREs.
>  
>  # Buttons
>  ButApply=Apply


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8



More information about the distro-pkg-dev mailing list