[RFC] plugin: fix getApplets()

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2010-07-02 09:37]:
> Hi,
> 
> The attached patch fixes AppletContext.getApplets() in the plugin.
> 
> The problem was that when the constructor PluginAppletViewer was
> called, panel was null. This null panel was then added to the list
> of all panels. Future calls to getApplets() will get to this null
> panel and throw a NullPointerException. The patch sets panel to the
> actual AppletPanel before adding it to the list of all panels.
> 
> This fixes a bug with applets on sbm.no not working. Please see [1]
> for the reproducer and user feedback on the patch. Ok to commit?
> 
> Cheers,
> Omair
> 
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=506730

Looks good! Please go ahead and commit.

> diff -r 7649271c60ab plugin/icedteanp/java/sun/applet/PluginAppletViewer.java
> --- a/plugin/icedteanp/java/sun/applet/PluginAppletViewer.java	Wed Jun 30 19:15:49 2010 -0400
> +++ b/plugin/icedteanp/java/sun/applet/PluginAppletViewer.java	Thu Jul 01 15:38:57 2010 -0400
> @@ -393,8 +393,7 @@
>           if (oldFrame != null && handle == oldFrame.handle)
>               return;
>  
> -         PluginAppletViewer newFrame = new PluginAppletViewer(handle, identifier, statusMsgStream, heightFactor, widthFactor);
> -         newFrame.panel = panel;
> +         PluginAppletViewer newFrame = new PluginAppletViewer(handle, identifier, statusMsgStream, heightFactor, widthFactor, panel);
>  
>           if (oldFrame != null) {
>               applets.remove(oldFrame.identifier);
> @@ -425,13 +424,14 @@
>        */
>       private PluginAppletViewer(long handle, final int identifier, 
>                           PrintStream statusMsgStream, double heightFactor, 
> -                         double widthFactor) {
> +                         double widthFactor, AppletViewerPanel appletPanel) {
>           
>           super(handle, true);
>           this.statusMsgStream = statusMsgStream;
>           this.identifier = identifier;
>           this.proposedHeightFactor = heightFactor;
>           this.proposedWidthFactor = widthFactor;
> +         this.panel = appletPanel;
>  
>           if (!appletPanels.contains(panel))
>               appletPanels.addElement(panel);