[RFC] plugin: fix getApplets()

Omair Majid omajid at redhat.com
Thu Jul 8 11:34:15 PDT 2010


On 07/08/2010 01:52 PM, Deepak Bhole wrote:
> * Omair Majid<omajid at redhat.com>  [2010-07-02 09:37]:
>> Hi,
>>
>> The attached patch fixes AppletContext.getApplets() in the plugin.
>>
>> The problem was that when the constructor PluginAppletViewer was
>> called, panel was null. This null panel was then added to the list
>> of all panels. Future calls to getApplets() will get to this null
>> panel and throw a NullPointerException. The patch sets panel to the
>> actual AppletPanel before adding it to the list of all panels.
>>
>> This fixes a bug with applets on sbm.no not working. Please see [1]
>> for the reproducer and user feedback on the patch. Ok to commit?
>>
>> Cheers,
>> Omair
>>
>> [1] https://bugzilla.redhat.com/show_bug.cgi?id=506730
>
> Looks good! Please go ahead and commit.
>

Thanks. Committed as changeset bf5edcaa5f78.

Cheers,
Omair



More information about the distro-pkg-dev mailing list