RFC: Test set for systemtap instrumentation

[Andrew John Hughes]

On 3 March 2010 17:08,  <jon.vanalten at redhat.com> wrote:
>
> ----- "Andrew John Hughes" <gnu_andrew at member.fsf.org> wrote:
>>
>> I'll leave Mark to comment on the actual SystemTap usage.  I don't
>> see
>> any additions to the Makefile.am to make this test build and run.
>> Assuming it can be automated, it needs a check-systemtap target which
>> check-local depends on and whose body is inside an if
>> ENABLE_SYSTEMTAP.
>
> Right, I wasn't sure if it should be added to the automated testing.
>

If it is automated, it should.  Otherwise, you're relying on people
remembering to run it (and working out how to in the first place).

>>The script seems to have hardcoded locations:
>>
>> +JAVA_EXEC="java"
>> +JAVAC_EXEC="javac"
>> +JVM_DIR="/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/jre/lib/amd64/server/"
>> +JVM_SO="-ljvm"
>> +INCLUDE_DIR="-I/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/include/
>> -I/usr/lib/jvm/java-1.6.0-openjdk-1.6.0.0.x86_64/include/linux/"
>>
>> These are only likely to work on x86_64 Fedora boxes.  The script
>> should take the JAVA_HOME as an argument and calculate the paths from
>> this.  The Makefile can pass the location of the just-built IcedTea
>> to
>> the script.
>>
>
> Yes, this is a problem.  Although, there is already such an argument; these would only be used if the script was called without the argument.  I'm actually rewriting the script in perl for various reasons, and will be making use of Config{archname} to get around this in both the no-argument (testing system-installed java) and with-argument (testing local build) case.  Note that even with $JAVA_HOME, script would still need to know the arch to find the directory in which libjvm.so lives; (jre/lib/<ARCH>/server), needed to compile and run JNI code.
>

uname -m will give you the arch of the host box, but as with
JAVA_HOME, you should pass the arch in from the Makefile.am.  All
these issues are already resolved there (e.g. the pulseaudio build
builds JNI code):

        $(CC) $(CFLAGS) -fPIC -I$(ICEDTEA_BOOT_DIR)/include/linux
-I$(ICEDTEA_BOOT_DIR)/include \
         -I$(PULSE_JAVA_NATIVE_BUILDDIR) -o $@ -c $<

so just reuse these variables.  You can always make the script a .in
file and generate it using configure, but I think arguments are
preferable so it can be run manually.

> Thanks for taking a look.  I'll re-post soon with updates.
>
> jon
>
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8