RFC: [patch] Shark fix memory corruption bug when accessing mattr outside of defined scope.

[Xerxes Rånby]

The memory used for mattr during sharkCompiler::sharkCompiler can have
been reallocated before its contents are used because the args vector
refers to the mattr memory outside of matts valid scope. The attached
patch fixed this issue.

If you have got hit by this bug then you will see shark exit early with
an odd error messages like
": Unknown command line argument 't-failed-fuse-candidates'. Try: ' -help'"
because LLVM are trying to parse reused memory for its command line
arguments.

Ok to push?
Ok to push to icedtea6-1.7 release branch?

2010-03-04  Xerxes Rånby  <xerxes at zafena.se>

    * ports/hotspot/src/share/vm/shark/sharkCompiler.cpp
    (sharkCompiler::sharkCompiler): Move mattr define to make its memory
    valid in the scope where it are used by the args vector.

Cheers and have a great day!
Xerxes


-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_shark_mattr_scope.patch
Type: text/x-diff
Size: 642 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20100304/79331ef6/fix_shark_mattr_scope.patch