[icedtea-web] RFC: integrate proxy configuration into netx/plugin

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2010-11-15 12:27]:
> Hi,
> 
...
> +
> +    /**
> +     * Returns true if the host is the hostname or the IP address of the
> +     * localhost
> +     */
> +    private boolean isLocalHost(String host) {
> +        if (host.equals("localhost")) {
> +            return true;
> +        }
> +
> +        if (host.equals("127.0.0.1")) {
> +            return true;
> +        }
> +
> +        try {
> +            if (host.equals(InetAddress.getLocalHost().getHostName())) {
> +                return true;
> +            }
> +        } catch (UnknownHostException e) {
> +            // continue
> +        }
> +
> +        try {
> +            if (host.equals(InetAddress.getLocalHost().getHostAddress())) {
> +                return true;
> +            }
> +        } catch (UnknownHostException e) {
> +            // continue
> +        }
> +
> +        return false;
> +    }
> +

The above check will fail for something like 127.0.0.2 which is also
local. Can't we use InetAddress.isLoopbackAddress() here?

...

Rest looks fine to me.

Cheers,
Deepak