[icedtea-web] RFC: integrate proxy configuration into netx/plugin

[Omair Majid]

On 11/17/2010 04:24 PM, Deepak Bhole wrote:
> * Omair Majid<omajid at redhat.com>  [2010-11-15 12:27]:
>> Hi,
>>
> ...
>> +
>> +    /**
>> +     * Returns true if the host is the hostname or the IP address of the
>> +     * localhost
>> +     */
>> +    private boolean isLocalHost(String host) {
>> +        if (host.equals("localhost")) {
>> +            return true;
>> +        }
>> +
>> +        if (host.equals("127.0.0.1")) {
>> +            return true;
>> +        }
>> +
>> +        try {
>> +            if (host.equals(InetAddress.getLocalHost().getHostName())) {
>> +                return true;
>> +            }
>> +        } catch (UnknownHostException e) {
>> +            // continue
>> +        }
>> +
>> +        try {
>> +            if (host.equals(InetAddress.getLocalHost().getHostAddress())) {
>> +                return true;
>> +            }
>> +        } catch (UnknownHostException e) {
>> +            // continue
>> +        }
>> +
>> +        return false;
>> +    }
>> +
>
> The above check will fail for something like 127.0.0.2 which is also
> local. Can't we use InetAddress.isLoopbackAddress() here?
>

I actually wanted to avoid doing a DNS lookup on the (possibly 
untrusted) hostname (not sure if that even matters), but I cant see 
another way. Fixed using the method you suggested. The last two 
conditions are still present as they check if something like 
"fully.qualified.domain.name" is the local machine, something that 
isLoopbackAddress does not do.

>
> Rest looks fine to me.
>

Thanks,
Omair
-------------- next part --------------
A non-text attachment was scrubbed...
Name: integrate-proxy-04.patch
Type: text/x-patch
Size: 41074 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20101118/88f35b73/integrate-proxy-04.patch