[RFC] plugin: dont shadow *Version variables in JNLPFile

Omair Majid omajid at redhat.com
Fri Oct 1 08:08:01 PDT 2010


Hi,

The varaibles specVersion and fileVersion defined in PluginBridge are 
shadowing the variables with the same names in JNLPFile. This means that 
whenever JNLPFile tries to access fileVersion and specVerion for a 
plugin, it will see nulls. I am not sure if this matters - most of the 
uses of Version variables check for nulls. However, since we are setting 
specVersion and fileVersion explicitly, they should be set to the 
correct values.

The attached patch makes sure the variables are not shadowed.

Cheers,
Omair
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icedtea6-plugin-dont-shadow-versions.patch
Type: text/x-patch
Size: 723 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20101001/e2218b45/icedtea6-plugin-dont-shadow-versions.patch 


More information about the distro-pkg-dev mailing list