[RFC] plugin: dont shadow *Version variables in JNLPFile

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2010-10-01 11:15]:
> Hi,
> 
> The varaibles specVersion and fileVersion defined in PluginBridge
> are shadowing the variables with the same names in JNLPFile. This
> means that whenever JNLPFile tries to access fileVersion and
> specVerion for a plugin, it will see nulls. I am not sure if this
> matters - most of the uses of Version variables check for nulls.
> However, since we are setting specVersion and fileVersion
> explicitly, they should be set to the correct values.
> 
> The attached patch makes sure the variables are not shadowed.
> 
> Cheers,
> Omair

> diff -r 674b1799df8c netx/net/sourceforge/jnlp/PluginBridge.java
> --- a/netx/net/sourceforge/jnlp/PluginBridge.java	Wed Sep 29 13:37:46 2010 -0700
> +++ b/netx/net/sourceforge/jnlp/PluginBridge.java	Fri Oct 01 10:47:59 2010 -0400
> @@ -35,8 +35,6 @@
>  
>  public class PluginBridge extends JNLPFile
>  {
> -    Version specVersion = new Version("1.0");
> -    Version fileVersion = new Version("1.1");
>  
>      String name;
>      String[] jars = new String[0];
> @@ -48,6 +46,8 @@
>                          int width, int height, Hashtable atts)
>      throws Exception
>      {
> +        specVersion = new Version("1.0");
> +        fileVersion = new Version("1.1");
>          this.codeBase = codebase;
>          this.sourceLocation = documentBase;
>  

Looks fine to me. OK for 1.7/1.8/1.9 and HEAD.

Deepak