[icedtea-web] RFC: regression in certificate information dialogs

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2010-10-28 14:10]:
> Hi,
> 
> There has been a regression in netx which causes some some dialogs
> (those showing information about certificates) to be disposed
> immediately after they shown. The attached patch makes these dialogs
> modal again so they are not disposed instantly.
> 

What introduced this regression?

This is a pretty bad regression :/ We need a better way to test and
assess commit feasibility.

OK for HEAD.

Deepak

> ChangeLog
> 2010-10-28  Omair Majid  <omajid at redhat.com>
> 
>     * netx/net/sourceforge/jnlp/security/SecurityWarningDialog.java
>     (showMoreInfoDialog): Make dialog modal.
>     (showCertInfoDialog): Likewise.
>     (showSingleCertInfoDialog): Likewise.
>     (initDialog): Use setModality instead of setModal.
> 
> Any thoughts or comments?
> 
> Thanks,
> Omair

> diff -r 5566a5487109 netx/net/sourceforge/jnlp/security/SecurityWarningDialog.java
> --- a/netx/net/sourceforge/jnlp/security/SecurityWarningDialog.java	Wed Oct 27 15:55:55 2010 -0700
> +++ b/netx/net/sourceforge/jnlp/security/SecurityWarningDialog.java	Thu Oct 28 13:29:37 2010 -0400
> @@ -167,6 +167,7 @@
>                  SecurityWarningDialog dialog =
>                          new SecurityWarningDialog(DialogType.MORE_INFO, null, null,
>                          jarSigner);
> +                dialog.setModalityType(ModalityType.APPLICATION_MODAL);
>                  dialog.setVisible(true);
>                  dialog.dispose();
>          }
> @@ -181,6 +182,7 @@
>                  SecurityWarningDialog dialog = new SecurityWarningDialog(DialogType.CERT_INFO,
>                          null, null, jarSigner);
>                  dialog.setLocationRelativeTo(parent);
> +                dialog.setModalityType(ModalityType.APPLICATION_MODAL);
>                  dialog.setVisible(true);
>                  dialog.dispose();
>          }
> @@ -195,6 +197,7 @@
>                          JDialog parent) {
>                  SecurityWarningDialog dialog = new SecurityWarningDialog(DialogType.SINGLE_CERT_INFO, c);
>                          dialog.setLocationRelativeTo(parent);
> +                        dialog.setModalityType(ModalityType.APPLICATION_MODAL);
>                          dialog.setVisible(true);
>                          dialog.dispose();
>          }
> @@ -219,7 +222,7 @@
>                          dialogTitle = "Security Warning";
>  
>                  setTitle(dialogTitle);
> -                setModal(false);
> +                setModalityType(ModalityType.MODELESS);
>  
>                  setDefaultCloseOperation(DISPOSE_ON_CLOSE);
>