[icedtea-web] RFC: regression in certificate information dialogs

[Omair Majid]

On 10/28/2010 02:14 PM, Deepak Bhole wrote:
> * Omair Majid<omajid at redhat.com>  [2010-10-28 14:10]:
>> Hi,
>>
>> There has been a regression in netx which causes some some dialogs
>> (those showing information about certificates) to be disposed
>> immediately after they shown. The attached patch makes these dialogs
>> modal again so they are not disposed instantly.
>>
>
> What introduced this regression?
>

This is the commit that changes the setModal from true to false:
http://icedtea.classpath.org/hg/icedtea-web/rev/eb998ed0ab1a

This regression was introduced because we wanted to allow multiple 
applets to show their own security warning dialogs without interfering 
with security dialogs from other applets. For example if signed applets 
A and B are launched, each will show their own security prompt. If A 
shows the security warning first, the user can not accept the warning 
from B without accepting or rejecting the warning from A first. One of 
the ideas behind this changeset was to allow this behaviour.

Unfortunately, some dialogs which are not technically security warnings 
also rely on this class, and their behaviour changed which slipped by 
unnoticed.

> This is a pretty bad regression :/ We need a better way to test and
> assess commit feasibility.
>

Yes, it is a bad regression, but it does not affect any security prompts 
- it only affects dialogs that explain why the security warning is being 
shown. I agree that we need a process to ensure these things don't 
happen again.

> OK for HEAD.
>

Thanks, I will push this commit shortly.

Cheers,
Omair

> Deepak
>
>> ChangeLog
>> 2010-10-28  Omair Majid<omajid at redhat.com>
>>
>>      * netx/net/sourceforge/jnlp/security/SecurityWarningDialog.java
>>      (showMoreInfoDialog): Make dialog modal.
>>      (showCertInfoDialog): Likewise.
>>      (showSingleCertInfoDialog): Likewise.
>>      (initDialog): Use setModality instead of setModal.
>>
>> Any thoughts or comments?
>>
>> Thanks,
>> Omair