[icedtea-web] RFC: allow running make clean multiple times

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2010-10-28 16:09]:
> Hi,
> 
> Running make clean twice causes the second make clean to fail as it
> can not delete the non-existing directory $(PLUGIN_DIR)/launcher.
> The patch checks that the directory exists before trying to delete
> it. make clean will still fail if the directory exists and is not
> empty.
> 

I'd just change it to use rmdir --ignore-fail-on-non-empty. Or is there
a reason for the if check to exist?

Deepak

> ChangeLog
> 2010-10-28  Omair Majid  <omajid at redhat.com>
> 
>     * Makefile.am
>     (clean-IcedTeaPlugin): Remove launcher directory only if it exists.
> 
> Thanks,
> Omair

> diff -r 33f17695e034 Makefile.am
> --- a/Makefile.am	Tue Oct 26 18:14:11 2010 -0400
> +++ b/Makefile.am	Thu Oct 28 15:57:36 2010 -0400
> @@ -190,7 +190,9 @@
>  clean-IcedTeaPlugin:
>  	rm -f $(PLUGIN_DIR)/launcher/*.o
>  	rm -f $(PLUGIN_DIR)/launcher/pluginappletviewer
> -	rmdir $(PLUGIN_DIR)/launcher
> +	if [ -e $(PLUGIN_DIR)/launcher ]; then \
> +		rmdir $(PLUGIN_DIR)/launcher ; \
> +	fi
>  	rm -f $(PLUGIN_DIR)/*.o
>  	rm -f $(PLUGIN_DIR)/IcedTeaPlugin.so
>  	if [ $(abs_top_srcdir) != $(abs_top_builddir) ]; then \