[icedtea-web] RFC: allow running make clean multiple times
Omair Majid
omajid at redhat.com
Thu Oct 28 14:18:36 PDT 2010
On 10/28/2010 04:57 PM, Deepak Bhole wrote:
> * Omair Majid<omajid at redhat.com> [2010-10-28 16:09]:
>> Hi,
>>
>> Running make clean twice causes the second make clean to fail as it
>> can not delete the non-existing directory $(PLUGIN_DIR)/launcher.
>> The patch checks that the directory exists before trying to delete
>> it. make clean will still fail if the directory exists and is not
>> empty.
>>
>
> I'd just change it to use rmdir --ignore-fail-on-non-empty. Or is there
> a reason for the if check to exist?
>
Andrew Hughes (in the recent discussion related to other Makefile fixes)
said "I _want_ rmdir to fail if the launcher directory contains anything
other than compiled objects." [1]. Hence the check.
Thanks,
Omair
[1]
http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-October/010678.html
More information about the distro-pkg-dev
mailing list